rmannibucau commented on PR #2430: URL: https://github.com/apache/maven/pull/2430#issuecomment-2943172217
> However, the current implementation violates the DRY (Don't Repeat Yourself) principle because the logic is not placed where it belongs—during object initialization via the constructor. Guillaume explained you it is not true so not sure why you insist on that theoritical but wrong assumption > If code requires search-and-replace edits, that’s always a red flag (code smell) and warrants special attention due to the high risk involved. Code was done to not be in that pattern as your previous link explain. So we are all good, do we close the PR then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
