elharo commented on code in PR #2373:
URL: https://github.com/apache/maven/pull/2373#discussion_r2131957514
##########
impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelInterpolatorTest.java:
##########
@@ -486,14 +505,18 @@ public void
shouldInterpolateSourceDirectoryReferencedFromResourceDirectoryCorre
.build();
final SimpleProblemCollector collector = new SimpleProblemCollector();
- Model out = interpolator.interpolateModel(
- model, null, createModelBuildingRequest(context).build(),
collector);
assertCollectorState(0, 0, 0, collector);
- List<Resource> outResources = out.getBuild().getResources();
- Iterator<Resource> resIt = outResources.iterator();
-
- assertEquals(model.getBuild().getSourceDirectory(),
resIt.next().getDirectory());
+ assertEquals(
Review Comment:
don't do this. This is much less clear than the code we had. Do not inline
local variables with a method call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]