Pankraz76 commented on code in PR #2373:
URL: https://github.com/apache/maven/pull/2373#discussion_r2131981691
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelInterpolator.java:
##########
@@ -101,21 +104,14 @@ interface InnerInterpolator {
@Override
public Model interpolateModel(
Model model, Path projectDir, ModelBuilderRequest request,
ModelProblemCollector problems) {
- InnerInterpolator innerInterpolator = createInterpolator(model,
projectDir, request, problems);
Review Comment:
this is actually not the case for the sonar but or my immediate used.
its not returned but we should for just just consider this:
https://github.com/apache/maven/pull/2436/commits/2a68134f458ed4d20888ea4cd7e67088d71ae216
<img width="1799" alt="image"
src="https://github.com/user-attachments/assets/a982cdc1-efff-479d-86ee-cf3aaa9c8d0f"
/>
having fields only used for coupling for the reason of documenting
(coupling) the code its very broad overhead imho buts thats future topic. first
lets get rid of all the real gunk around, slowing everything down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]