jira-importer commented on issue #872:
URL: 
https://github.com/apache/maven-javadoc-plugin/issues/872#issuecomment-2957358713

   **[Bill 
Shannon](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=bshannon)**
 commented
   
   Sorry, just getting back to this...
   
   I'm not a proxy expert, but my understanding is that the communication 
between the client and the proxy server is always http, never https.  That's 
why Maven's interpretation of the proxy configuration seems wrong.
   
   I'm not clear on whether your suggested approach is just for the javadoc 
plugin or for Maven in general.  Maven in general needs to be fixed, but I 
assume we're just talking about the javadoc plugin here.
   
   If an https proxy is configured but no http proxy is configured, why would 
you use that proxy for non proxy hosts?  The non proxy hosts are configured 
per-protocol.  If you're trying to connect using https, and there's an https 
proxy configured, and that proxy configuration specifies nonProxyHosts, and 
you're trying to connect to one of those hosts, you should NOT use the 
configured proxy.
   
   Because Maven in general only allows one proxy to be active, I have to 
resort to configuring that proxy for the http protocol, and then pass command 
line parameters to configure the https proxy, e.g., "-Dhttps.proxyHost=\<proxy> 
-Dhttps.proxyPort=80".  Since the JDK doesn't allow nonProxyHosts to be 
specified separately for the https protocol, the nonProxyHosts for the http 
protocol should be used.
   
   The goal should be that any http or https connections made in the code are 
consistent with what the JDK will do when javadoc is invoked separately, and 
that you pass the appropriate JDK proxy properties to the separately invoked 
javadoc tool to achieve that.  And there has to be a way to configure the proxy 
for both http and https protocols.  You can either interpret the single Maven 
proxy configuration to apply to both, or you can also interpret the JDK 
properties passed to Maven to complete the proxy configuration.
   
   And yes, I'm not worried about ftp, and don't really know what to do with it 
here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to