jira-importer commented on issue #872:
URL: 
https://github.com/apache/maven-javadoc-plugin/issues/872#issuecomment-2957358705

   **[Michael 
Osipov](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=michael-o)**
 commented
   
   Bill, I have checked PR now and I am still not happy, but this isn't related 
to your PR in particular. These days people assume that an HTTP proxy will also 
handle HTTPS via `CONNECT`. I highly doubt that folks will configure a proxy 
explicitly for `https`, in the case they do, our code is broken becaue 
`Settings#getActiveProxy()` will not take that into consideration. I know there 
is no perfect solution, but I would like to take this approach:
   
   * Iterate over all proxies and collect active (first) ones for HTTP and HTTPS
   * If HTTPS is availabe, use it for HTTPS as well as for non proxy hosts, but 
if and only if proxy for HTTP is not available
   * Else use HTTP proxy for both HTTP and HTTPS
   
   Does this make sense? The only other protocol `URLConnection` supports is 
FTP, but I think no one will use that protocol for Javadoc.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to