jira-importer commented on issue #958: URL: https://github.com/apache/maven-javadoc-plugin/issues/958#issuecomment-2957364873
**[Benjamin Bentmann](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=bentmann)** commented Looks fine to me. Just a few notes: - `@requiresDependencyResolution runtime` seems unnecessary, the plugin doesn't query project dependencies - The mojo parameter `enabled` should probably be renamed to `skip` for consistency with some other Maven plugins - A common base class for the two mojos could help to reduce some code redudancy like common parameters or the logic to skip unsupported artifact types I'm awaiting the confirmation of your CLA record before importing this to the sandbox. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
