jira-importer commented on issue #958: URL: https://github.com/apache/maven-javadoc-plugin/issues/958#issuecomment-2957364861
**[Benjamin Bentmann](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=bentmann)** commented > I'll prepare a maven-signer-plugin patch to have something to start with > Great! If you already happen to be an Apache comitter, you could as well just hack in the [Maven sandbox](http://svn.apache.org/repos/asf/maven/sandbox/trunk/plugins/) which should be writtable to you then. > Thinking about it, should such a mojo also contain the functionality of the maven-gpg-plugin > As a front note, I'm not an experienced user of either of these two plugins, so my comments might not be well-founded. Nevertheless, I believe jarsigning and GPG - while serving a similar purpose - are distinct tasks. The first creating a new/updated JAR, the second merely creating a detached signature. Also, different tools with different options are involved. For these reasons, I believe that generalizing/abstracting of these tasks would rather bring unnecessary complexity when compared to two independent plugins, each one focusing on its particular job. KISS. > Is there already some ArtifactSigner > Not that I know of. Both the maven-jar-plugin and maven-gpg-plugin currently just end up building the command line to execute the external tool. > Provide an ArtifactSigner component in group org.apache.maven.shared.something and use that in the plugin ? > Personally, I would just start with a single plugin. You can still design your code to have the signing logic nicely encapsulated as a Plexus component and delegate to that from your mojo class. But unless somebody actually calls for reusage of this signing component outside of the context of the plugin, what's the reason to require two releases to get going? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
