[
https://issues.apache.org/jira/browse/SCM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17962707#comment-17962707
]
ASF GitHub Bot commented on SCM-723:
------------------------------------
jira-importer commented on issue #922:
URL: https://github.com/apache/maven-scm/issues/922#issuecomment-2964633151
**[Robert
Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)**
commented
Let me try to rephrase my comments and add links to the related code:
[HgUtils.execute()](http://maven.apache.org/scm/maven-scm-providers/maven-scm-provider-hg/xref/org/apache/maven/scm/provider/hg/HgUtils.html#83)
is responsible for every execution of a Mercurial command.
`org.codehaus.plexus.util.cli.Commandline` is the '_framework_' for executing.
It has intelligence to adjust the executable based on the OS.
This class is used by every SCM Provider and a lot of Maven plugins.
`CommandLine` opens a new shell to have full control over environment
variables. So the last argument contains what will actually be executed. This
is not how _you_ want to execute the command, because it'll close the shell
ASAP. So you're only interested in the content of the last argument. In fact
I'm quite happy it is not escaped, otherwise I had to unescape that line first
before I could excecute it and analyze the output. If you still don't agree,
discuss it with, share your thoughts
[here](https://jira.codehaus.org/browse/PLXUTILS) (that'll be my last redirect
;) ).
My intention was to point you to (what I believe is) the real cause.
Convince me I'm wrong by trying the release a single module project (I predict
it'll succeed). Also convince me I'm wrong by replacing the quotes(I predict
the same issue).
> On windows mvn release:prepare fails trying commit changed pom.xml files.
> -------------------------------------------------------------------------
>
> Key: SCM-723
> URL: https://issues.apache.org/jira/browse/SCM-723
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Components: maven-scm-provider-mercurial (hg)
> Affects Versions: 1.8.1
> Environment: Apache Maven 3.0.5
> (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 14:51:28+0100)
> Maven home: C:\maven
> Java version: 1.7.0_21, vendor: Oracle Corporation
> Java home: C:\Java\64bit\jdk1.7.0_21\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 8", version: "6.2", arch: "amd64", family: "windows"
> Reporter: Børre Gaup
> Priority: Major
> Attachments: MavenReleasePluginBug.png
>
>
> The commit includes a commit message, but the double quotes (") is not
> escaped so the command fails. On Mac (and Linux?) the commit message is in
> single quotes (') so that works.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
