[
https://issues.apache.org/jira/browse/SCM-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17962894#comment-17962894
]
ASF GitHub Bot commented on SCM-762:
------------------------------------
jira-importer commented on issue #967:
URL: https://github.com/apache/maven-scm/issues/967#issuecomment-2964636511
**[Dan
Tran](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=dantran)**
commented
In order to do full validation, there is a need to use
File.getCannonicalPath() which forces the construction to add IOException
throws clause. It is not desirable since it break the api.
> Validate ScmFileSet's external filelist agrument
> ------------------------------------------------
>
> Key: SCM-762
> URL: https://issues.apache.org/jira/browse/SCM-762
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Improvement
> Components: maven-scm-api
> Affects Versions: 1.9
> Reporter: Dan Tran
> Assignee: Dan Tran
> Priority: Major
>
> ScmFileSet has this public method
> {code}
> /**
> * Create a file set with the files provided, relative to basedir.
> *
> * @param basedir directory files are relative to
> * @param files list of File objects, files that the set will contain,
> have to be relative to basedir
> */
> public ScmFileSet( File basedir, List<File> files )
> {
> ....
> }
> However, passing 'files' argument is not validated for its contract. without
> that, the exception get thrown at very deep into provider and harder to
> understand
> {code>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
