[ 
https://issues.apache.org/jira/browse/SCM-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17962892#comment-17962892
 ] 

ASF GitHub Bot commented on SCM-762:
------------------------------------

jira-importer opened a new issue, #967:
URL: https://github.com/apache/maven-scm/issues/967

   **[Dan 
Tran](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=dantran)** 
opened 
**[SCM-762](https://issues.apache.org/jira/browse/SCM-762?redirect=false)** and 
commented
   
   ScmFileSet has this public method
   
   ```
       /**
        * Create a file set with the files provided, relative to basedir.
        *
        * @param basedir directory files are relative to
        * @param files   list of File objects, files that the set will contain, 
have to be relative to basedir
        */
       public ScmFileSet( File basedir, List<File> files )
       {
          ....
       }
   
   However, passing 'files' argument is not validated for its contract.  
without that, the exception get thrown at very deep into provider and harder to 
understand
   {code>
   ```
   
   
   
   ---
   
   **Affects:** 1.9
   




> Validate ScmFileSet's external filelist agrument
> ------------------------------------------------
>
>                 Key: SCM-762
>                 URL: https://issues.apache.org/jira/browse/SCM-762
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Improvement
>          Components: maven-scm-api
>    Affects Versions: 1.9
>            Reporter: Dan Tran
>            Assignee: Dan Tran
>            Priority: Major
>
> ScmFileSet has this public method
> {code}
>     /**
>      * Create a file set with the files provided, relative to basedir.
>      *
>      * @param basedir directory files are relative to
>      * @param files   list of File objects, files that the set will contain, 
> have to be relative to basedir
>      */
>     public ScmFileSet( File basedir, List<File> files )
>     {
>        ....
>     }
> However, passing 'files' argument is not validated for its contract.  without 
> that, the exception get thrown at very deep into provider and harder to 
> understand
> {code>



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to