slawekjaranowski commented on code in PR #515:
URL: https://github.com/apache/maven-parent/pull/515#discussion_r2535198132
##########
docs/src/site/apt/index.apt.vm:
##########
@@ -118,6 +118,15 @@ mvn scm-publish:publish-scm
* History
+** 46
+
+ A <<GitHub ribbon>> has been added to the generated site to provide a direct
link to the project's GitHub repository.
+
+ A new configuration property <<<maven.site.gitHubProjectId>>> has been
introduced.
+ By default, this property is set to <<<$\{project.artifactId\}>>>, is used
to resolve the <<GitHub>> repository URL for the ribbon link.
Review Comment:
> 1. for multi-module projects, a fixed value has to be added to the build
root (can I add a commit to the PR?)
of course - always
> 2. what are instructions when ribbon has to be disabled, like on
maven-site or doxia-site? or do we really want the ribbon also on main sites?
it is not easy, when we have defined ribbon in parent site.xml - always will
be used ...
look at code
https://github.com/apache/maven-fluido-skin/blob/de8a32f384bc01f1b527f20d00c920bf458482c5/src/main/resources/META-INF/maven/site-macros.vm#L466
we can try to set `projectId` to empty value ... to avoid rendering .. but
I'm not sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
