hboutemy commented on code in PR #515:
URL: https://github.com/apache/maven-parent/pull/515#discussion_r2535900359


##########
docs/src/site/apt/index.apt.vm:
##########
@@ -118,6 +118,15 @@ mvn scm-publish:publish-scm
 
 * History
 
+** 46
+
+  A <<GitHub ribbon>> has been added to the generated site to provide a direct 
link to the project's GitHub repository.
+
+  A new configuration property <<<maven.site.gitHubProjectId>>> has been 
introduced.
+  By default, this property is set to <<<$\{project.artifactId\}>>>, is used 
to resolve the <<GitHub>> repository URL for the ribbon link.

Review Comment:
   good question
   
   for Maven site or Doxia site, we already have an edit button that goes to 
the source of the page
   <img width="342" height="48" alt="image" 
src="https://github.com/user-attachments/assets/33d36d8b-2708-446a-b7cf-798bd31fb96c";
 />
   
   and getting the same visual ribbon everywhere IMHO adds more confusion: of 
course, we need to see, I'm anticipating in my head



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to