cstamas commented on code in PR #1714:
URL: https://github.com/apache/maven-resolver/pull/1714#discussion_r2620146584
##########
maven-resolver-util/src/main/java/org/eclipse/aether/util/version/package-info.java:
##########
@@ -21,22 +21,22 @@
* Version scheme for parsing/comparing versions and utility classes.
* <p>
* Contains the "generic" scheme {@link
org.eclipse.aether.util.version.GenericVersionScheme}
- * that serves the purpose of "factory" (and/or parser) for all corresponding
elements (all those are package private).
+ * that serves as a "factory" (and/or parser) for corresponding package
private classes.
* <p>
- * On the other hand, the {@link
org.eclipse.aether.util.version.UnionVersionRange} is universal implementation
of
+ * On the other hand, the {@link
org.eclipse.aether.util.version.UnionVersionRange} is a universal
implementation of
* "unions" of various {@link org.eclipse.aether.version.VersionRange}
instances.
* <p>
- * Below is the <em>Generic Version Spec</em> described:
- * <p>
- * Version string is parsed into version according to these rules:
+ * A version string is parsed according to the
+ *
<href='https://maven.apache.org/pom.html#Version_Order_Specification'>Version
Order Specification</a>.
Review Comment:
Nope. The refd URL points to `maven-artifact` spec, that is known to differ
from this one (see resolver/maven issues). In Maven 4 the Resolver Version is
becoming "the standard" (as new Maven4 API delegates to it), and
`maven-artifact` module is put under `compat/`, as it is being deprecated with
many other things there.
Goal is to stop this current split-brain situation, and duplication of this
very important aspect of Maven. Moreover, `maven-artifact` class `Artifact` is
basically a mixed bag of dependencies (has scope etc) and artifacts. That thing
should be just forgotten.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
