cstamas commented on code in PR #1714:
URL: https://github.com/apache/maven-resolver/pull/1714#discussion_r2620228714
##########
maven-resolver-util/src/main/java/org/eclipse/aether/util/version/package-info.java:
##########
@@ -21,22 +21,22 @@
* Version scheme for parsing/comparing versions and utility classes.
* <p>
* Contains the "generic" scheme {@link
org.eclipse.aether.util.version.GenericVersionScheme}
- * that serves the purpose of "factory" (and/or parser) for all corresponding
elements (all those are package private).
+ * that serves as a "factory" (and/or parser) for corresponding package
private classes.
* <p>
- * On the other hand, the {@link
org.eclipse.aether.util.version.UnionVersionRange} is universal implementation
of
+ * On the other hand, the {@link
org.eclipse.aether.util.version.UnionVersionRange} is a universal
implementation of
* "unions" of various {@link org.eclipse.aether.version.VersionRange}
instances.
* <p>
- * Below is the <em>Generic Version Spec</em> described:
- * <p>
- * Version string is parsed into version according to these rules:
+ * A version string is parsed according to the
+ *
<href='https://maven.apache.org/pom.html#Version_Order_Specification'>Version
Order Specification</a>.
Review Comment:
Or, align the site page with Resolver GenericVersion, then it could be fine
to point there.
But the goal is to stop having this duality, duplication and keep trying to
align these two classes, aside maven-artifact one is being totally overloaded
with other things as well. Just stop pouring energy into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
