elharo commented on code in PR #11700:
URL: https://github.com/apache/maven/pull/11700#discussion_r2768528194
##########
impl/maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java:
##########
@@ -870,6 +899,49 @@ private void initProject(MavenProject project,
ModelBuilderResult result) {
project.setRemoteArtifactRepositories(remoteRepositories);
}
+ /**
+ * Warns about legacy directory usage in a modular project. Two cases
are handled:
+ * <ul>
+ * <li>Case 1: The default legacy directory exists on the filesystem
(e.g., src/main/java exists)</li>
+ * <li>Case 2: An explicit legacy directory is configured that
differs from the default</li>
+ * </ul>
+ * Legacy directories are unconditionally ignored in modular projects
because it is not clear
Review Comment:
I'm not comfortable with this. If we can't dispatch, I think we need to hard
fail the build rather than simply ignoring the content. Let the user figure out
how to rearrange the project to make the build pass. A warning is not enough
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
