ascheman commented on code in PR #11700:
URL: https://github.com/apache/maven/pull/11700#discussion_r2771006987
##########
impl/maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java:
##########
@@ -870,6 +899,49 @@ private void initProject(MavenProject project,
ModelBuilderResult result) {
project.setRemoteArtifactRepositories(remoteRepositories);
}
+ /**
+ * Warns about legacy directory usage in a modular project. Two cases
are handled:
+ * <ul>
+ * <li>Case 1: The default legacy directory exists on the filesystem
(e.g., src/main/java exists)</li>
+ * <li>Case 2: An explicit legacy directory is configured that
differs from the default</li>
+ * </ul>
+ * Legacy directories are unconditionally ignored in modular projects
because it is not clear
Review Comment:
Sounds feasible to me. I would think this should be another acceptance
criterion (AC8) in the overall concept to document that additional behaviour?
It would be consistent with AC6 (where we also fail for mixed modular/classic
`<sources>`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
