kwin commented on code in PR #1793:
URL: https://github.com/apache/maven-resolver/pull/1793#discussion_r2790000633
##########
maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk11/src/main/java/org/eclipse/aether/transport/jdk/JdkTransporter.java:
##########
@@ -545,10 +545,13 @@ public X509Certificate[] getAcceptedIssuers() {
HttpTransporterUtils.getHttpLocalAddress(session,
repository).orElse(null));
if (repository.getProxy() != null) {
- ProxySelector proxy = ProxySelector.of(new InetSocketAddress(
- repository.getProxy().getHost(),
repository.getProxy().getPort()));
-
- builder.proxy(proxy);
+ InetSocketAddress proxyAddress = new InetSocketAddress(
+ repository.getProxy().getHost(),
repository.getProxy().getPort());
+ if (proxyAddress.isUnresolved()) {
+ throw new IllegalStateException(
Review Comment:
Do the other transporters behave the same? If so we should have an IT,
otherwise I would rather warn only instead of throwing an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
