cstamas commented on code in PR #1793:
URL: https://github.com/apache/maven-resolver/pull/1793#discussion_r2790019976
##########
maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk11/src/main/java/org/eclipse/aether/transport/jdk/JdkTransporter.java:
##########
@@ -545,10 +545,13 @@ public X509Certificate[] getAcceptedIssuers() {
HttpTransporterUtils.getHttpLocalAddress(session,
repository).orElse(null));
if (repository.getProxy() != null) {
- ProxySelector proxy = ProxySelector.of(new InetSocketAddress(
- repository.getProxy().getHost(),
repository.getProxy().getPort()));
-
- builder.proxy(proxy);
+ InetSocketAddress proxyAddress = new InetSocketAddress(
+ repository.getProxy().getHost(),
repository.getProxy().getPort());
+ if (proxyAddress.isUnresolved()) {
+ throw new IllegalStateException(
Review Comment:
Again, Resolver does not have any IT suite.
I wholeheartedly agree with assessment, but am unsure we want to start
creating IT suite now (just before releases) as it would delay things for quite
some.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
