ascheman commented on code in PR #11702:
URL: https://github.com/apache/maven/pull/11702#discussion_r2805077254
##########
impl/maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java:
##########
@@ -422,19 +422,21 @@ void testModularSourcesInjectResourceRoots() throws
Exception {
}
/**
- * Tests that when modular sources are configured alongside explicit
legacy resources,
- * the legacy resources are ignored and a warning is issued.
+ * Tests that when modular sources are configured alongside explicit
legacy resources, an error is raised.
* <p>
* This verifies the behavior described in the design:
- * - Modular projects with explicit legacy {@code <resources>}
configuration should issue a warning
+ * - Modular projects with explicit legacy {@code <resources>}
configuration should raise an error
* - The modular resource roots are injected instead of using the legacy
configuration
* <p>
- * Acceptance Criterion: AC2 (unified source tracking for all lang/scope
combinations)
+ * Acceptance Criteria:
+ * - AC2 (unified source tracking for all lang/scope combinations)
+ * - AC8 (legacy directories error - supersedes AC7 which originally used
WARNING)
Review Comment:
As AC7 has already become part of the `master` branch implementation, I do
not want to override it now. I consider it better to invalidate it and write a
new one. As they all belong to proper legacy source/resource handling wrt to
the new `<sources>` configuration element, I proceed with the numbering. I am
also preparing some overall documentation, covering all aspects (an
update/replacement for [the Confluence
page](https://cwiki.apache.org/confluence/x/84TMFw) where it all began.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
