ascheman commented on code in PR #11702:
URL: https://github.com/apache/maven/pull/11702#discussion_r2802884373
##########
impl/maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java:
##########
@@ -693,27 +693,27 @@ private void initProject(MavenProject project,
ModelBuilderResult result) {
/*
* `sourceDirectory`, `testSourceDirectory` and
`scriptSourceDirectory`
- * are ignored if the POM file contains at least one enabled
<source> element
+ * are not used if the POM file contains at least one enabled
<source> element
Review Comment:
OK, I fully agree that we should not require something on the Super POM by
now but just use the classic directories as fallback if nothing is explicitly
configured. Nevertheless, I will create a new Acceptance Criterion to express
that design choice - we are back at (another) AC9 then 😉:
## AC9 Definition (Non-Modular Projects)
**AC9** (Legacy directory handling for non-modular projects):
For **non-modular projects** using `<sources>`:
1. **When `<sources>` has Java for a scope**: Legacy directories are
rejected if they differ from the default (explicit configuration detected)
2. **When `<sources>` has no Java for a scope**: Legacy directories are used
as **implicit fallback** only if they match the default (could be inherited)
_I already made some progress implementing and testing this and will deliver
test cases for both AC8 and AC9_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
