ctubbsii commented on code in PR #551:
URL:
https://github.com/apache/maven-apache-parent/pull/551#discussion_r2806245814
##########
pom.xml:
##########
@@ -533,8 +531,7 @@ under the License.
</activation>
<properties>
<!--
https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html,
affects m-compiler-p and m-javadoc-p -->
- <maven.compiler.release>8</maven.compiler.release>
-
<minimalJavaBuildVersion>${maven.compiler.release}</minimalJavaBuildVersion>
+ <maven.compiler.release>${javaVersion}</maven.compiler.release>
Review Comment:
I wish I had reviewed this prior to release. This profile should set all 3.
Some plugins still read `maven.compiler.source` and/or `maven.compiler.target`
(formatting tools, static analysis tools, etc.) Not all plugins have been
updated to know about `maven.compiler.release` and use it as an alternative. It
was really convenient to have these set in one spot in the parent POM. Now that
they are removed, they need to be added to every child POM to avoid breaking
any builds using plugins that don't use `maven.compiler.release`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
