ctubbsii commented on code in PR #551:
URL:
https://github.com/apache/maven-apache-parent/pull/551#discussion_r2806284046
##########
pom.xml:
##########
@@ -533,8 +531,7 @@ under the License.
</activation>
<properties>
<!--
https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html,
affects m-compiler-p and m-javadoc-p -->
- <maven.compiler.release>8</maven.compiler.release>
-
<minimalJavaBuildVersion>${maven.compiler.release}</minimalJavaBuildVersion>
+ <maven.compiler.release>${javaVersion}</maven.compiler.release>
Review Comment:
Also, the premise of this PR was a bit misleading: users already could set
all three with one property in apache-35. They only needed to set
`maven.compiler.target`. That's not ideal, and having the single `javaVersion`
property is certainly better (though I prefer all lowercase, `java.version` or
similar), but I still think the profile for 9+ should set all 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
