elharo commented on code in PR #11576:
URL: https://github.com/apache/maven/pull/11576#discussion_r3303281097
##########
api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java:
##########
Review Comment:
odd that we have to pass null here
##########
api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java:
##########
@@ -203,71 +228,93 @@ default Map<String, String> namespaces() {
@Nullable
Object inputLocation();
- // Deprecated methods that delegate to new ones
@Deprecated(since = "4.0.0", forRemoval = true)
@Nonnull
default String getName() {
return name();
}
+ /**
+ * @deprecated Use {@link #namespaceUri()} instead.
+ */
@Deprecated(since = "4.0.0", forRemoval = true)
@Nonnull
default String getNamespaceUri() {
return namespaceUri();
}
+ /**
+ * @deprecated Use {@link #prefix()} instead.
+ */
@Deprecated(since = "4.0.0", forRemoval = true)
@Nonnull
default String getPrefix() {
return prefix();
}
-
+ /**
+ * @deprecated Use {@link #value()} instead.
+ */
@Deprecated(since = "4.0.0", forRemoval = true)
@Nullable
default String getValue() {
return value();
}
+ /**
+ * @deprecated Use {@link #attributes()} instead.
+ */
@Deprecated(since = "4.0.0", forRemoval = true)
@Nonnull
default Map<String, String> getAttributes() {
return attributes();
}
+ /**
+ * @deprecated Use {@link #attribute(String)} instead.
+ */
@Deprecated(since = "4.0.0", forRemoval = true)
@Nullable
default String getAttribute(@Nonnull String name) {
return attribute(name);
}
+ /**
+ * @deprecated Use {@link #children()} instead.
+ */
@Deprecated(since = "4.0.0", forRemoval = true)
@Nonnull
default List<XmlNode> getChildren() {
return children();
}
+ /**
+ * @deprecated Use {@link #child(String)} instead.
+ */
@Deprecated(since = "4.0.0", forRemoval = true)
@Nullable
default XmlNode getChild(String name) {
return child(name);
}
+ /**
+ * @deprecated Use {@link #inputLocation()} instead.
+ */
@Deprecated(since = "4.0.0", forRemoval = true)
@Nullable
default Object getInputLocation() {
return inputLocation();
}
/**
- * @deprecated use {@link XmlService#merge(XmlNode, XmlNode, Boolean)}
instead
+ * @deprecated Use {@link XmlService#merge(XmlNode, XmlNode, Boolean)}
instead.
Review Comment:
Is this right? It doesn't match what's called below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
