anukalp2804 commented on PR #11576:
URL: https://github.com/apache/maven/pull/11576#issuecomment-4546588197
> _Fully automatic review from Claude Code_
>
> ## Review of PR #11576 — Docs xmlnode deprecations followup
> The PR is much improved from earlier iterations — the unrelated files
(Language.java, DefaultSourceRoot, DefaultProjectManagerTest) are removed, the
redundant `since 4.0.0.` text in Javadoc is cleaned up per reviewer feedback,
and the `@deprecated` tags are consistently capitalized with trailing periods.
Good work.
>
> Two remaining issues:
>
> ### 1. Missing `@deprecated` Javadoc on `getName()` (consistency gap)
> Every other deprecated getter method in this PR gets a `@deprecated`
Javadoc added (`getNamespaceUri`, `getPrefix`, `getValue`, `getAttributes`,
`getAttribute`, `getChildren`, `getChild`, `getInputLocation`), but `getName()`
is the only one left without it. The comment `// Deprecated methods that
delegate to new ones` was removed, but no replacement Javadoc was added. It
should get the same treatment:
>
> ```java
> /**
> * @deprecated Use {@link #name()} instead.
> */
> @Deprecated(since = "4.0.0", forRemoval = true)
> @Nonnull
> default String getName() {
> return name();
> }
> ```
>
> ### 2. Minor: removed blank line before `getValue()` (formatting
inconsistency)
> The blank line between `getPrefix()` and `getValue()` was removed, while
blank lines between all other methods are preserved. This looks unintentional.
>
> Everything else looks correct — the `{@link}` targets all resolve to real
constants/methods in `XmlService`, and the scope of the PR is now properly
focused on XmlNode only.
Thank you for review and guidance. I’ve updated the Javadocs and made the
formatting consistent. Please review it and let me know if any changes need
from my side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
