Bukama commented on code in PR #96:
URL: https://github.com/apache/maven-jmod-plugin/pull/96#discussion_r3336590925


##########
src/it/mjmod-20-set-main-class/pom.xml:
##########
@@ -49,11 +49,21 @@
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-compiler-plugin</artifactId>
-                    <version>@version.maven-compiler-plugin@</version>
+                    <!-- When this version is not set to 3.8.0, but to 
@version.maven-compiler-plugin@ then jar-plugin 4.0.0-beta gets pulled in which 
is not defined anywhere, but is the latest in my local repository.
+                    4.0.0-beta ofc is not compatible with Maven 3.9.x.
+                    if you then set the jar-plugin to 
@version.maven-jar-plugin@, the java module (of the module-info) gets not found 
-->

Review Comment:
   Yes changing the compiler version to `@version.maven-compiler-plugin@` pulls 
in a 4.0.0-beta-1 jar-plugin version.
   
   ```
   [DEBUG] org.apache.maven.plugins:maven-jar-plugin/maven-metadata.xml was not 
found in file:///C:/Users/matth/.m2/repository during a previous attempt. This 
failure was cached in the local repository and resolution is not be reattempted 
until the update interval of local.central has elapsed or updates are forced
   [DEBUG] Skipped remote request for 
org.apache.maven.plugins:maven-jar-plugin/maven-metadata.xml, locally cached 
metadata up-to-date
   [WARNING] Ignoring incompatible plugin version 4.0.0-beta-1
   org.apache.maven.plugin.PluginIncompatibleException: 
   The plugin org.apache.maven.plugins:maven-jar-plugin:4.0.0-beta-1 has unmet 
prerequisites: 
        Required Maven version 4.0.0-beta-3 is not met by current version 3.9.16
   
   ```
   
   And yes this absolute does not makes sense, but I tried it multiple times.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to