slawekjaranowski commented on code in PR #96:
URL: https://github.com/apache/maven-jmod-plugin/pull/96#discussion_r3336652758


##########
src/it/mjmod-20-set-main-class/pom.xml:
##########
@@ -49,11 +49,21 @@
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-compiler-plugin</artifactId>
-                    <version>@version.maven-compiler-plugin@</version>
+                    <!-- When this version is not set to 3.8.0, but to 
@version.maven-compiler-plugin@ then jar-plugin 4.0.0-beta gets pulled in which 
is not defined anywhere, but is the latest in my local repository.
+                    4.0.0-beta ofc is not compatible with Maven 3.9.x.
+                    if you then set the jar-plugin to 
@version.maven-jar-plugin@, the java module (of the module-info) gets not found 
-->

Review Comment:
   🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to