HarshMehta112 opened a new pull request, #369:
URL: https://github.com/apache/maven-help-plugin/pull/369
Following this checklist to help us incorporate your
contribution quickly and easily:
## Problem
Since Maven 3.10.0, `mvn help:describe -Dcmd=<phase>` shows `Not defined`
for every phase in the lifecycle, regardless of the actual plugin bindings.
Example with `maven-plugin` packaging:
- compile: Not defined
- test: Not defined
- deploy: Not defined
## Root Cause
In Maven 3.10.0 (`apache/maven#11916`),
`Lifecycle.getDefaultLifecyclePhases()`
now returns an **empty `Map`** (not `null`) for the `default` lifecycle,
because
packaging-specific bindings are not part of the lifecycle definition
itself.
`DescribeMojo` used the old `null` check to decide which path to take:
```java
// 3.9.x: returns null for default lifecycle → correct path taken
// 3.10.0: returns empty Map → falls into else branch → all phases "Not
defined"
if (lifecycle.getDefaultPhases() == null) {
// use packaging-specific lifecycleMappings ← correct
} else {
// use lifecycle.getDefaultPhases() ← empty map in 3.10.0
}
```
Fix
```java
- Replace getDefaultPhases() == null with
getDefaultLifecyclePhases() == null ||
getDefaultLifecyclePhases().isEmpty()
- Replace getDefaultPhases() == null with
getDefaultLifecyclePhases() == null ||
getDefaultLifecyclePhases().isEmpty()
- Replace deprecated getDefaultPhases() / getPhases() with
getDefaultLifecyclePhases() / getLifecyclePhases() throughout
- Use lifecycle.getId() instead of hardcoded "default" when looking up
packaging-specific bindings
- Add null guard for getLifecyclePhases() which can return null if the
lifecycle mapping was constructed without setting phases
```
Testing
Three unit tests added to DescribeMojoTest:
```java
- testDescribeCommandPackagingSpecificPhaseShowsBindings — regression test:
verifies correct plugin bindings shown when builtinPhases is empty (3.10.0
behavior)
- testDescribeCommandBuiltinLifecyclePhaseShowsBindings — verifies
clean/site
lifecycles still use their built-in bindings directly
- testDescribeCommandUnknownPhaseThrows — verifies MojoExecutionException
thrown for unknown phase names
```
Fixes #367
Related: apache/maven#12181
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
