gnodet opened a new pull request, #12205:
URL: https://github.com/apache/maven/pull/12205
## Summary
- **Eliminate temp directory** in `PluginUpgradeStrategy` — build effective
models from original file paths instead of copying POMs to a temp directory
that lacked `.mvn` for root detection
- **Fix `DefaultModelBuilder.doReadFileModel()`** to handle `${revision}`
parent versions: enter parent resolution block for expression versions, skip
`isParentWithinRootDirectory` when root directory is a fallback guess, and
accept parent version match when version contains an expression
- Add unit test, integration test, and fix existing
`PluginUpgradeStrategyTest`
Fixes the "Parent POM is located above the root directory" error that
occurred in `mvnup apply` for all CI-friendly projects using `${revision}`
(bigtop-manager, guacamole-client, hbase-connectors, logging-log4j-samples).
## Test plan
- [x] `DefaultModelBuilderTest` — 7 tests pass (including new
`testCiFriendlyVersion`)
- [x] `PluginUpgradeStrategyTest` — 27 tests pass (including fixed
`shouldDetectInheritedPluginsFromRemoteParent`)
- [x] `MavenITgh12184CIFriendlyParentVersionTest` — 2 ITs pass (property
from POM, property from CLI)
- [x] Existing CI-friendly ITs pass (`MavenITgh11196CIFriendlyProfilesTest`,
`MavenITmng8744CIFriendlyTest`)
- [x] `mvnup apply` on all 4 affected projects produces no "parent above
root" errors
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
