Hiteshsai007 commented on PR #12332:
URL: https://github.com/apache/maven/pull/12332#issuecomment-4776264584
Thanks for the thorough second review! All items addressed:
1. **`your-database.db`** — removed from the repo.
2. **`.replace('\\', '/')`** — removed from
`ConditionProfileActivatorTest.testExecutableWithAbsolutePath()`.
3. **Windows test coverage** — added `contextWithPathAndOs()` test helper
that sets `os.name` in the `ProfileActivationContext`, plus 3 new tests:
- `findsExecutableWithWindowsExtensionInPath`: PATH search finds
`my-tool.exe` when searching for `my-tool`
- `findsExecutableWithWindowsExtensionByDirectPath`: direct path
`/path/to/tool` probes `/path/to/tool.exe`
- `doesNotAppendExtensionOnNonWindows`: confirms no extension probing
when `os.name` is `Linux`
4. **`isExecutableFile()` comment** — rewritten to accurately describe that
the caller is responsible for extension probing (not that it always does it).
5. **Direct paths on Windows** — `executable('/path/to/tool')` now also
tries `.exe`/`.cmd`/`.bat`/`.com` extensions, matching the PATH-search
behaviour.
Regarding **consumer POM stripping (Option 1)** — agreed that's a good
follow-up. Happy to tackle it in a separate PR once this one lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
