Hiteshsai007 commented on PR #12332: URL: https://github.com/apache/maven/pull/12332#issuecomment-4776787214
Thanks for the thorough review and the `LGTM`! I've just pushed one final commit to address the minor nit by deduplicating the `contextWithPath` and `contextWithPathAndOs` test helpers. Everything should be fully sorted now. I agree that stripping `executable()` conditions from consumer POMs (Option 1) is a great next step, and I'd be happy to tackle that in a separate follow-up PR once this one is merged. Let me know if there's anything else needed before merging! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
