gnodet commented on code in PR #12410:
URL: https://github.com/apache/maven/pull/12410#discussion_r3550035441


##########
compat/maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java:
##########
@@ -1160,6 +1163,15 @@ private boolean isValidId(String id) {
         return true;
     }
 
+    /**
+     * An id or version made up only of {@code .} or {@code ..} is a 
filesystem path-traversal segment. The dotted

Review Comment:
   The names _are_ illegal, see 
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.html, 
section 4.13:
   
   > The special filename dot shall refer to the directory specified by its 
predecessor. The special filename dot-dot shall refer to the parent directory 
of its predecessor directory. As a special case, in the root directory, dot-dot 
may refer to the root directory itself.
   
   You can't create a file named `.` or `..`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to