cstamas commented on PR #1955: URL: https://github.com/apache/maven-resolver/pull/1955#issuecomment-4957725511
Few remarks here: * I dislike SPI pulling in logger, that is wrong IMHO * logging on DEBUG makes not much sense, as these kind of errors "happen out of the blue" (not in debug), and then if user tries to catch them (and enabled debug) these bugs are usually not happening :smile: I'd rather not introduce logging here, but some sort of `Consumer` that could maybe just collect issues, and possible shown at build end in case of failure. Overall the idea is very good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
