kwin commented on PR #1955: URL: https://github.com/apache/maven-resolver/pull/1955#issuecomment-4958109654
Thanks for the reviews. > Few remarks here: ... > I'd rather not introduce logging here, but some sort of `Consumer` that could maybe just collect bodies, and have them possibly shown at build end, for example in case of build failure. Overall the idea is very good. Any pointers how to not make it too verbose? Collecting all failed response bodies (even extracts) may be too heavyweight or do you suggest only collecting the first/last one? Who should be responsible for logging? 1. RepositorySystemSession.CloseableSession` with its `close()` method or 2. The consumer setting up the session (Maven in most cases) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
