elharo commented on code in PR #129:
URL: https://github.com/apache/maven-shared-jar/pull/129#discussion_r3610949892
##########
src/main/java/org/apache/maven/shared/jar/classes/JarClasses.java:
##########
@@ -130,12 +130,48 @@ public void setDebugPresent(boolean hasDebugSymbols) {
this.isDebugPresent = hasDebugSymbols;
}
+ /**
+ * Get the highest Java class version available in any class files. While
the JAR may work on earlier JVMs if particular
+ * classes are not used, this is the minimum JVM version that guarantees
compatibility.
+ *
+ * @return the highest Java class version available in any class files, or
null if not known.
+ *
+ * @since 3.2.1
+ */
+ public String getMaxJavaClassVersion() {
+ return maxJavaClassVersion;
+ }
+
+ /**
+ * Set the highest Java class version available in any class files. While
the JAR may work on earlier JVMs if particular
+ * classes are not used, this is the minimum JVM version that guarantees
compatibility.
+ *
+ * @param maxJavaClassVersion the highest Java class version available in
any class files.
+ *
+ * @since 3.2.1
+ */
+ public void setMaxJavaClassVersion(String maxJavaClassVersion) {
Review Comment:
why do we need a setter at all?
##########
src/main/java/org/apache/maven/shared/jar/classes/JarClasses.java:
##########
@@ -57,10 +57,10 @@ public class JarClasses {
private boolean isDebugPresent;
/**
- * The highest JVM revision available in any class files. While the JAR
may work on earlier JVMs if particular
- * classes are not used, this is the minimum JVM that guarantees
compatibility.
+ * The highest Java class version available in any class files. While the
JAR may work on earlier JVMs if particular
+ * classes are not used, this is the minimum JVM version that guarantees
compatibility.
Review Comment:
so is it JVM version or Java byte code version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
