elharo commented on code in PR #129:
URL: https://github.com/apache/maven-shared-jar/pull/129#discussion_r3613434739
##########
src/main/java/org/apache/maven/shared/jar/classes/JarClasses.java:
##########
@@ -57,10 +57,10 @@ public class JarClasses {
private boolean isDebugPresent;
/**
- * The highest JVM revision available in any class files. While the JAR
may work on earlier JVMs if particular
- * classes are not used, this is the minimum JVM that guarantees
compatibility.
+ * The highest Java class version available in any class files. While the
JAR may work on earlier JVMs if particular
Review Comment:
I don't think "Java class version" is a thing. This also needs to be very
clear about whether you're talking about the class file format version or the
Java version
##########
src/main/java/org/apache/maven/shared/jar/classes/JarClasses.java:
##########
@@ -57,10 +57,10 @@ public class JarClasses {
private boolean isDebugPresent;
/**
- * The highest JVM revision available in any class files. While the JAR
may work on earlier JVMs if particular
- * classes are not used, this is the minimum JVM that guarantees
compatibility.
+ * The highest Java class version available in any class files. While the
JAR may work on earlier JVMs if particular
+ * classes are not used, this is the minimum JVM version that guarantees
compatibility.
Review Comment:
If this is right, the field name is wrong. I'm prettys sure the field name
is wrong whether this is right or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
