slachiewicz commented on PR #928: URL: https://github.com/apache/maven-wagon/pull/928#issuecomment-5319460800
Added a second commit: `HugeFileDownloadTest` also comes off `PlexusTestCase`. It belongs here rather than in its own PR because it needs the `junit-jupiter` declaration this PR adds — on its own it fails to compile with `package org.junit.jupiter.api does not exist`. The container was only supplying `Wagon.ROLE` `"http"`, which is `HttpWagon`, and `AbstractHttpClientWagon` declares no injected collaborators, so `new HttpWagon()` is equivalent to the lookup. `getBasedir()` becomes a local method with the semantics `PlexusTestCase` gave it, so the four call sites are unchanged. Dropping the base class also removed the inherited `assertTrue`, hence the static import. `ScpWagonWithProxyTest` is deliberately not included. `AbstractJschWagon` has three `@Inject` fields — `knownHostsProvider`, `interactiveUserInfo` and one more — so instantiating it directly would leave them null and the test would keep passing while exercising something different. Migrating it needs a real container, which means introducing `plexus-testing`; that is a dependency decision and should be its own change. Verification is unchanged: 295 `<testcase>` elements before and after, 2 skipped in both, per class identical, with `HugeFileDownloadTest` still at 2. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
