slachiewicz commented on PR #929: URL: https://github.com/apache/maven-wagon/pull/929#issuecomment-5319511546
Added the second commit from #928: `HugeFileDownloadTest` comes off `PlexusTestCase`. This branch's copy was byte-identical to master's before its migration, so master's result is taken verbatim. The container there was only supplying `Wagon.ROLE` `"http"`, which is `HttpWagon`, and `AbstractHttpClientWagon` declares no injected collaborators, so a plain constructor is equivalent. `ScpWagonWithProxyTest` is deliberately not included: `AbstractJschWagon` has three `@Inject` fields, so instantiating it directly would leave them null and the test would keep passing while exercising something different. That one needs a real container, i.e. `plexus-testing`, which should be its own change. Verification after this commit: 295 `<testcase>` elements, 2 skipped, per class identical, and this run finished with **no** errors at all — the `testProxiedRequest` error noted in the description did not reappear, which is consistent with it being the order-dependent interference described there rather than anything introduced here. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
