wilx commented on code in PR #829:
URL:
https://github.com/apache/maven-shade-plugin/pull/829#discussion_r3865055689
##########
src/main/java/org/apache/maven/plugins/shade/DefaultShader.java:
##########
@@ -189,6 +240,30 @@ public void shade(ShadeRequest shadeRequest) throws
IOException, MojoExecutionEx
}
}
+ private List<File> findMultiReleaseInputs(ShadeRequest shadeRequest)
throws IOException {
+ List<File> result = new ArrayList<>();
+ for (File jar : shadeRequest.getJars()) {
+ Manifest manifest = null;
+ if (jar.isDirectory()) {
+ File manifestFile = new File(jar, JarFile.MANIFEST_NAME);
+ if (manifestFile.isFile()) {
+ try (InputStream input =
Files.newInputStream(manifestFile.toPath())) {
+ manifest = new Manifest(input);
+ }
+ }
+ } else {
+ try (JarFile jarFile = newJarFile(jar)) {
+ manifest = jarFile.getManifest();
+ }
+ }
+ if (manifest != null
Review Comment:
This does not looks like an improvement to me.
##########
src/main/java/org/apache/maven/plugins/shade/DefaultShader.java:
##########
@@ -189,6 +240,30 @@ public void shade(ShadeRequest shadeRequest) throws
IOException, MojoExecutionEx
}
}
+ private List<File> findMultiReleaseInputs(ShadeRequest shadeRequest)
throws IOException {
+ List<File> result = new ArrayList<>();
+ for (File jar : shadeRequest.getJars()) {
+ Manifest manifest = null;
+ if (jar.isDirectory()) {
+ File manifestFile = new File(jar, JarFile.MANIFEST_NAME);
+ if (manifestFile.isFile()) {
+ try (InputStream input =
Files.newInputStream(manifestFile.toPath())) {
+ manifest = new Manifest(input);
+ }
+ }
+ } else {
+ try (JarFile jarFile = newJarFile(jar)) {
+ manifest = jarFile.getManifest();
+ }
+ }
+ if (manifest != null
Review Comment:
This does not look like an improvement to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
