wilx commented on PR #829: URL: https://github.com/apache/maven-shade-plugin/pull/829#issuecomment-5428908741
> JPMS is complex so perhaps there's something I'm misunderstanding here, but for now I think this is something we should not do. I'm not saying this PR is bad or can be fixed to be accepted. I'm saying this is a feature we should not have, and further work is unlikely to be accepted absent a clear and compelling explanation of why this should be done. We can discuss the exact function of the merging. But it should be merge eventually because people asked for it. The mental model for how this works is in the OP. It works as if you pooled all the partial sources into one module, made some necessary adjustments, and compiled it as a single module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
