goutamadwant opened a new pull request, #12910:
URL: https://github.com/apache/maven/pull/12910
Fixes #12602
## Summary
`ROProperties` copied only the direct entries from the source `Properties`
instance. Any values inherited through its defaults chain were therefore lost,
causing `getProperty` to return `null` for inherited properties.
This change snapshots the effective inherited string properties into a
private defaults object before copying the direct entries. This preserves
standard `Properties` behavior while:
- keeping inherited properties outside the direct map
- preserving recursive defaults
- preserving fallback through direct non-string values
- avoiding a mutable reference to the source defaults chain
- avoiding an additional allocation when no inherited defaults exist
The API implementation, internal XML implementation, and MDO generation
template use the same behavior.
## Tests
Added regression coverage for:
- direct and inherited properties
- recursive defaults
- direct string overrides
- direct non-string values with string defaults
- direct-map size and membership semantics
- isolation from later source-default mutations
Verification:
- `mvn clean verify`
- `mvn -pl api/maven-api-xml -am -Dtest=ImmutableCollectionsTest
-Dsurefire.failIfNoSpecifiedTests=false test`
`mvn -Prun-its clean install` was also attempted. The Core IT suite did not
complete locally because its extracted Maven distribution directory disappeared
during execution, resulting in cascading unrelated missing-file failures. Tests
executed before that point passed after the matching `4.0.x` IT support
artifacts were installed.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
