elharo commented on code in PR #12910:
URL: https://github.com/apache/maven/pull/12910#discussion_r3886444332
##########
api/maven-api-xml/src/main/java/org/apache/maven/api/xml/ImmutableCollections.java:
##########
@@ -374,6 +374,23 @@ private ROProperties(Properties props) {
}
}
+ private static Properties copyDefaults(Properties props) {
+ if (props == null) {
+ return null;
+ }
+ Properties defaults = null;
Review Comment:
I don't follow why you don't just create defaults here. Lazy initialization
is not obviously needed. What's the reasoning? Why return null when the
aergument is not null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
