goutamadwant commented on code in PR #12910:
URL: https://github.com/apache/maven/pull/12910#discussion_r3887200543
##########
api/maven-api-xml/src/main/java/org/apache/maven/api/xml/ImmutableCollections.java:
##########
@@ -374,6 +374,23 @@ private ROProperties(Properties props) {
}
}
+ private static Properties copyDefaults(Properties props) {
+ if (props == null) {
+ return null;
+ }
+ Properties defaults = null;
Review Comment:
right @elharo @gnodet . The lazy initialization was intended to avoid
allocating an empty `Properties` when no inherited defaults existed, but the
added complexity might not be justified here. The API copy now initializes it
eagerly, and I aligned the internal XML implementation and MDO template with
the same behavior. Let me know thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
