wilx commented on PR #298:
URL: https://github.com/apache/maven/pull/298#issuecomment-5468561934

   > a boolean flag seems insufficient for this purpose. The model problems 
themselves should be exposed to plugins that want to read them. I'd prefer to 
avoid half-measures. Is there a more complete approach possible here?
   
   A boolean is sufficient to implement the Enforcer rule.
   
   I do not have a use case for it but I agree that having access to the 
problem items might be useful. However, because I want to be able to use the 
Enforcer rules both with 3.10.x and 4.x Maven, there are some design problems:
   
   - Maven has `org.apache.maven.model.building.ModelProblem`. But the 
interface and related classes are deprecated in 4.x. I am sure introducing more 
uses of deprecated API is no go for 4.x branches. 
   - OTOH, porting the 4.x problem gathering code to 3.x also seems like 
something that would be rejected. It is a lot of code.
   - Introducing 3rd common representation is recreation of the XKCD 
[meme](https://xkcd.com/927/).
   
   What else could we do instead? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to