gnodet commented on PR #13066: URL: https://github.com/apache/maven/pull/13066#issuecomment-5574575452
One additional thought: this PR targets `master` (4.1.0), but the feature did not exist in 4.0.0. A `test-jar` consumer upgrading from 4.0.0 to 4.1.0 would suddenly get extra transitive dependencies they didn't have before — that could break builds (dependency conflicts, convergence enforcer rules, etc.). Even if the new behavior is correct, a silent behavioral change in a minor version can be painful. I'd suggest adding a user-facing property (e.g. `maven.resolver.testJarTransitiveDeps`) that: - defaults to `true` in 4.1.0+ - defaults to `false` under Maven 3 personality - can be explicitly overridden in either direction via `-D` or `.mvn/maven.config` This gives users a safety valve: if 4.1.0 breaks their build because of new transitive deps showing up, they can set it to `false` and deal with the migration on their own timeline. It also makes the Maven 3 personality handling cleaner — instead of a separate code path, it's just a different default for the same property. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
