gnodet-bot commented on code in PR #13066:
URL: https://github.com/apache/maven/pull/13066#discussion_r4026089151
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Constants.java:
##########
@@ -575,6 +575,16 @@ public final class Constants {
@Config(type = "java.lang.Boolean", defaultValue = "false")
public static final String MAVEN_MAVEN3_PERSONALITY =
"maven.maven3Personality";
+ /**
+ * User property for enabling transitive dependencies of consumed test
JARs.
+ * The effective default is {@code true} for Maven 4 semantics and {@code
false}
+ * when Maven 3 personality is enabled.
+ *
+ * @since 4.1.0
+ */
+ @Config(type = "java.lang.Boolean", defaultValue = "true")
+ public static final String MAVEN_TEST_JAR_TRANSITIVE_DEPS =
"maven.testJarTransitiveDeps";
Review Comment:
The Javadoc note about the conditional default was added in this push —
appreciated. However, a `@see` cross-reference to
`Features#testJarTransitiveDeps` is still missing, making it hard for readers
to find the method that actually computes the effective value. Suggest adding:
```suggestion
/**
* User property for enabling transitive dependencies of consumed test
JARs.
* The annotation default ({@code true}) applies to Maven 4 semantics;
Maven 3 personality
* ({@link #MAVEN_MAVEN3_PERSONALITY}) sets the effective default to
{@code false}.
*
* @see
org.apache.maven.api.feature.Features#testJarTransitiveDeps(java.util.Map)
* @since 4.1.0
*/
@Config(type = "java.lang.Boolean", defaultValue = "true")
public static final String MAVEN_TEST_JAR_TRANSITIVE_DEPS =
"maven.testJarTransitiveDeps";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
