gnodet commented on PR #13086: URL: https://github.com/apache/maven/pull/13086#issuecomment-5685879180
Addressing the scope concern raised in the latest re-review: The FATAL escalation for explicit `<relativePath>` is intentional. The compat `DefaultModelBuilder` previously emitted `Severity.WARNING` unconditionally — but that was the exact bug. When a user *explicitly* writes `<relativePath>../pom.xml</relativePath>` pointing at a POM whose GA doesn't match, that's a configuration error that warrants a hard failure, not a silent warning. This matches the Maven 4 `DefaultModelBuilder.mismatchRelativePathAndGA()` behavior exactly (`boolean warn = ... || childModel.getParent().getRelativePath() == null`). The distinction is: - `relativePath` omitted → Maven is probing the default location, user didn't explicitly declare it → WARNING (MNG-5146 fix) - `relativePath` explicitly set → user told Maven exactly where the parent is, and it's wrong → FATAL (correct, expected, intentional) This is not a scope creep — it's the correct interpretation of MNG-5146: the misleading message was specifically about the *implicit* probe case. Making explicit mismatches FATAL is the right behavioral complement, and gnodet's own review at 18:11 described exactly this pattern from Maven 4. _On behalf of @gnodet._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
