gnodet commented on code in PR #13086:
URL: https://github.com/apache/maven/pull/13086#discussion_r4020440275
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelBuilder.java:
##########
@@ -1426,18 +1426,49 @@ private Model readParentLocally(
}
private void mismatchRelativePathAndGA(Model childModel, Parent
parent, String groupId, String artifactId) {
+ boolean defaultPath = childModel.getParent().getRelativePath() ==
null;
Review Comment:
Fixed in 8feb0542b855d4fd33a43ac4e368992a5adb6a0f.
- Updated `MavenITmng8294ParentChecksTest.testitbadMismatch()` to match the
new message format: `"which resolves to ... instead of the declared parent
..."`.
- Simplified `defaultPath` to use the `parent` parameter directly instead of
`childModel.getParent().getRelativePath()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]