slachiewicz commented on PR #1189: URL: https://github.com/apache/maven-plugin-tools/pull/1189#issuecomment-5741087544
Read through the module. The problem it solves (a distro cannot build maven-plugin-plugin without a prior maven-plugin-plugin) is real, but this shape is hard to keep alive: it injects into four private fields of `JavaAnnotationsMojoDescriptorExtractor` by reflection, so any rename breaks it at runtime and only under `-Pbootstrap`, which CI does not run; it re-implements POM parent walking, property interpolation and dependency resolution with placeholder `dummy.jar` files; and it compiles all of `maven-plugin-plugin` a second time through `compileSourceRoots`. Before this can be considered I would want: a CI job that runs the profile, package-private constructors instead of reflection, and ideally a much smaller approach that boots the real mojo through a minimal Sisu container instead of duplicating its wiring. Converting to draft until then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
