fridrich commented on PR #1189: URL: https://github.com/apache/maven-plugin-tools/pull/1189#issuecomment-5742785855
> Before this can be considered I would want: > a CI job that runs the profile added > package-private constructors instead of reflection, and ideally a much smaller approach that boots the real mojo through a minimal Sisu container instead of duplicating its wiring. originally, my goal was not to add any code to maven-plugin-plugin to keep it completely pristine in order to leave the non-bootstrap path as untouched as possible. Your review actually helped me to come with a solution that is IMHO even more elegant even though it adds a main method to the org.apache.maven.plugin.plugin.DescriptorGeneratorMojo class. If this is good for you, I find it superior solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
