slachiewicz opened a new pull request, #1203:
URL: https://github.com/apache/maven-plugin-tools/pull/1203
Four rendering defects in the javadoc-to-help and javadoc-to-report
pipeline, each with a test that fails on the current code:
| Issue | Cause | Change |
|---|---|---|
| #823 | `JavadocInlineTagsToXhtmlConverter` matched `{@tag …}` with
`[^}]*`, so `{@code …${project.basedir}…}` ended at the property's brace and
the rest of the block was lost | a scanner that ends the tag at the balanced
closing brace; unbalanced input is left untouched |
| #845 | `HtmlToPlainTextConverter` appended `TextNode.text()`
(whitespace-normalised) for `<pre>` content and then collapsed runs of spaces
globally | `<pre>` content is taken verbatim and excluded from the collapsing |
| #807 | every `<li>` produced `\n * ` regardless of nesting | nested items
are indented two spaces per level; top-level output is unchanged |
| #822 | `GoalRenderer.getXhtmlWithValidatedLinks` validated every relative
link against the report output directory, and a link to a sibling goal page is
checked before that page is written | links to this report's own pages
(`<goal>-mojo.html`, `plugin-info.html`) are not validated against the
directory |
Verified: `mvn install` (unit tests, spotless, RAT) green; `-Prun-its` for
the `help-*`, `mplugin-324_javadoc`, `mplugin-363_help-reproducible`,
`java-basic-annotations*` and `annotation-with-inheritance*` ITs of
maven-plugin-plugin (12) and all 13 ITs of maven-plugin-report-plugin pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
